move download, build, and removal into a single RUN command to save space

Dockerfile

@@ -19,78 +19,85 @@ RUN apt-get update && apt-get install -y byacc bison diffutils flex make
 # grab some convenience packages for using it as a build "machine"
 RUN apt-get install -y vim
 
-# get ready to build things
-RUN mkdir -p /build /usr/man/man1 /opt
-
-# perform downloads first so they get cached during development; does it make any difference afterwards?
-RUN cd /build && curl -O http://zlib.net/zlib-${ZLIB_VERSION}.tar.gz
-RUN cd /build && curl -O https://www.hdfgroup.org/ftp/lib-external/jpeg/src/jpegsrc.v${JPEG_VERSION}.tar.gz
-RUN cd /build && curl -O https://www.hdfgroup.org/ftp/lib-external/szip/${SZIP_VERSION}/src/szip-${SZIP_VERSION}.tar.gz
-RUN cd /build && curl -O http://www.hdfgroup.org/ftp/HDF/releases/HDF${HDF4_VERSION}/src/hdf-${HDF4_VERSION}.tar.gz
-RUN cd /build && curl -O https://www.hdfgroup.org/ftp/HDF5/releases/hdf5-${HDF5_VERSION}/src/hdf5-${HDF5_VERSION}.tar.gz
-RUN cd /build && curl -O ftp://ftp.unidata.ucar.edu/pub/netcdf/netcdf-${NC4C_VERSION}.tar.gz
-RUN cd /build && curl -O ftp://ftp.unidata.ucar.edu/pub/netcdf/netcdf-fortran-${NC4F_VERSION}.tar.gz
+# this is our install dir for everything non-core
+RUN mkdir -p /opt
 
 # add zlib
 #RUN apt-get install -y zlib-devel
-RUN cd /build && tar xzf zlib-${ZLIB_VERSION}.tar.gz && \
+RUN mkdir -p /build && cd /build && \
+    curl -O http://zlib.net/zlib-${ZLIB_VERSION}.tar.gz && \
+    tar xzf zlib-${ZLIB_VERSION}.tar.gz && \
     cd zlib-${ZLIB_VERSION} && \
     ./configure && make -j4 && make install && \
-    cp configure.log /opt/config.log-zlib-${ZLIB_VERSION}
+    cp configure.log /opt/config.log-zlib-${ZLIB_VERSION} && \
+    rm -rf /build
 
 # add libjpeg
 #RUN apt-get install -y jpeg-devel
-RUN cd /build && tar xzf jpegsrc.v${JPEG_VERSION}.tar.gz && \
+RUN mkdir -p /build && cd /build && \
+    curl -O https://www.hdfgroup.org/ftp/lib-external/jpeg/src/jpegsrc.v${JPEG_VERSION}.tar.gz && \
+    tar xzf jpegsrc.v${JPEG_VERSION}.tar.gz && \
     cd jpeg-${JPEG_VERSION} && \
     ./configure && make -j4 && make install && \
-    cp config.log /opt/config.log-jpeg-${JPEG_VERSION}
+    cp config.log /opt/config.log-jpeg-${JPEG_VERSION} && \
+    rm -rf /build
 
 ## add szip
-#RUN cd /build && tar zxf szip-${SZIP_VERSION}.tar.gz && \
+#RUN mkdir -p /build && cd /build && curl -O https://www.hdfgroup.org/ftp/lib-external/szip/${SZIP_VERSION}/src/szip-${SZIP_VERSION}.tar.gz && \
+#    tar zxf szip-${SZIP_VERSION}.tar.gz && \
 #    cd szip-${SZIP_VERSION} && \
 #    ./configure --prefix="/usr" --disable-shared --with-pic && make -j4 && make install && \
-#    cp config.log /config/config.log-szip-${SZIP_VERSION}
-
-# FIXME: HDF4 currently claims it cannot build shared libraries for fortran? wtf?
-# https://lists.hdfgroup.org/pipermail/hdf-forum_lists.hdfgroup.org/2016-January/009163.html
-# enable-shared => disable-shared everywhere for now since we're most likely building static binaries anyways
+#    cp config.log /config/config.log-szip-${SZIP_VERSION} && \
+#    rm -rf /build
 
 # add hdf4
-RUN cd /build && mkdir -p /opt/hdf4 && tar xzf hdf-${HDF4_VERSION}.tar.gz && \
+RUN mkdir -p /build /opt/hdf4 && cd /build && \
+    curl -O http://www.hdfgroup.org/ftp/HDF/releases/HDF${HDF4_VERSION}/src/hdf-${HDF4_VERSION}.tar.gz && \
+    tar xzf hdf-${HDF4_VERSION}.tar.gz && \
     cd hdf-${HDF4_VERSION} && \
     CFLAGS="-fPIC -DHAVE_NETCDF -fno-strict-aliasing" \
     CXXFLAGS="-fPIC -DHAVE_NETCDF -fno-strict-aliasing" \
     ./configure --prefix="/opt/hdf4" --disable-netcdf --enable-fortran && make -j4 && make install && \
-    cp config.log /opt/hdf4/config.log-hdf4-${HDF4_VERSION}
+    cp config.log /opt/hdf4/config.log-hdf4-${HDF4_VERSION} && \
+    rm -rf /build
 
 # add hdf5
 # note - hdf5 post-1.8.11 now includes -ldl as a dependency
 # http://hdf-forum.184993.n3.nabble.com/Errors-compiling-against-Static-build-HDF5-1-8-11-Need-for-ldl-added-to-linker-arguments-td4026300.html
-RUN cd /build && mkdir -p /opt/hdf5 && tar xzf hdf5-${HDF5_VERSION}.tar.gz && \
+RUN mkdir -p /build /opt/hdf5 && cd /build && \
+    curl -O https://www.hdfgroup.org/ftp/HDF5/releases/hdf5-${HDF5_VERSION}/src/hdf5-${HDF5_VERSION}.tar.gz && \
+    tar xzf hdf5-${HDF5_VERSION}.tar.gz && \
     cd hdf5-${HDF5_VERSION} && \
     ./configure --prefix="/opt/hdf5" --with-pic --with-zlib="/opt/zlib" --enable-cxx --enable-fortran --enable-fortran2003 --with-pthread && make -j4 && make install && \
-    cp config.log /opt/hdf5/config.log-hdf5-${HDF5_VERSION}
+    cp config.log /opt/hdf5/config.log-hdf5-${HDF5_VERSION} && \
+    rm -rf /build
 
 # add netcdf-c
-RUN cd /build && mkdir -p /opt/netcdf4 && tar xzf netcdf-${NC4C_VERSION}.tar.gz && \
+RUN mkdir -p /build /opt/netcdf4 && cd /build && \
+    curl -O ftp://ftp.unidata.ucar.edu/pub/netcdf/netcdf-${NC4C_VERSION}.tar.gz && \
+    tar xzf netcdf-${NC4C_VERSION}.tar.gz && \
     cd netcdf-${NC4C_VERSION} && \
     CPPFLAGS="-I/opt/hdf4/include -I/opt/hdf5/include" \
     LDFLAGS="-L/opt/hdf4/lib -L/opt/hdf5/lib" \
     LD_LIBRARY_PATH="/opt/zlib/lib:/opt/jpeg/lib:/opt/hdf4/lib:/opt/hdf5/lib" \
     LIBS="-ldf -lhdf5_hl -lhdf5 -ljpeg -lm -lz" \
     ./configure --prefix="/opt/netcdf4" --enable-hdf4 --disable-dap --with-pic  && make -j4 && make install && \
-    cp config.log /opt/netcdf4/config.log-netcdf-${NC4C_VERSION}
+    cp config.log /opt/netcdf4/config.log-netcdf-${NC4C_VERSION} && \
+    rm -rf /build
 
 # add netcdf-fortran
 # compiling against this requires -lnetcdff (note the extra f)
-RUN cd /build && mkdir -p /opt/netcdf4 && tar xzf netcdf-fortran-${NC4F_VERSION}.tar.gz && \
+RUN mkdir -p /build /opt/netcdf4 && cd /build && \
+    curl -O ftp://ftp.unidata.ucar.edu/pub/netcdf/netcdf-fortran-${NC4F_VERSION}.tar.gz && \
+    tar xzf netcdf-fortran-${NC4F_VERSION}.tar.gz && \
     cd netcdf-fortran-${NC4F_VERSION} && \
     CPPFLAGS="-I/opt/hdf4/include -I/opt/hdf5/include -I/opt/netcdf4/include" \
     LDFLAGS="-L/opt/hdf4/lib -L/opt/hdf5/lib -L/opt/netcdf4/lib" \
     LD_LIBRARY_PATH="/opt/hdf4/lib:/opt/hdf5/lib:/opt/netcdf4/lib" \
     LIBS="-lnetcdf -ldf -lhdf5_hl -lhdf5 -ljpeg -lm -lz" \
     ./configure --prefix="/opt/netcdf4" --disable-dap --with-pic && make -j4 && make install && \
-    cp config.log /opt/netcdf4/config.log-netcdff-${NC4F_VERSION}
+    cp config.log /opt/netcdf4/config.log-netcdff-${NC4F_VERSION} && \
+    rm -rf /build
 
 # throw in some minor shell niceties
 RUN echo 'alias ls="ls --color=auto"' >> ~/.bashrc && \
@@ -102,6 +109,3 @@ RUN echo "export HDF4=/opt/hdf4" >> ~/.bashrc && \
     echo "export LD_LIBRARY_PATH=${HDF4}/lib:${HDF5}/lib:${NETCDF}/lib:${LD_LIBRARY_PATH}" >> ~/.bashrc && \
     echo "" >> ~/.bashrc
 
-# remove all the build cruft
-RUN rm -rf /build
-RUN rm -rf /usr/man