Fix most flake8 issues

metobsapi/__init__.py

-from metobsapi.server import app
+from metobsapi.server import app  # noqa
 
 from .version import __version__  # noqa

metobsapi/data_api.py

@@ -139,7 +139,7 @@ def calc_num_records(begin, end, interval):
 
 
 def calc_file_size(num_records, num_streams):
-    """Number of bytes returned for a text based format"""
+    """Get number of bytes returned for a text based format."""
     # estimate about 7 bytes (overhead + data characters) per data point
     return num_records * num_streams * 7.0
 

metobsapi/files_api.py

@@ -175,14 +175,13 @@ bitsadmin /resume myDownloadJob
 bitsadmin /SetNotifyCmdLine myDownloadJob \"%SystemRoot%\\system32\\bitsadmin.exe\" \"%SystemRoot%\\syste,32\\bitsadmin.exe /complete myDownloadJob\"
 bitsadmin /monitor
 
-"""
+"""  # noqa
 
     if frame is not None and not frame.empty:
         urls = frame["url"]
         directories = []
         commands = []
-        for idx, url in enumerate(urls):
-            relpath = frame["relpath"][idx]
+        for relpath in frame["relpath"]:
             directory = os.path.dirname(relpath).replace("/", "\\")
 
             if directory not in directories:

metobsapi/server.py

@@ -41,13 +41,13 @@ CORS(app, resources=r"/api/*", allow_headers="Content-Type")
 
 @app.route("/api/")
 def index():
-    """Main App Documentation"""
+    """Get Main App Documentation."""
     return render_template("index.html")
 
 
 @app.route("/api/files")
 def files_index():
-    """Files API Documentation"""
+    """Get Files API Documentation."""
     return render_template(
         "files_index.html",
         archive_info=file_responses.ARCHIVE_STREAMS,
@@ -57,7 +57,7 @@ def files_index():
 
 @app.route("/api/data")
 def data_index():
-    """Data API Documentation"""
+    """Get Data API Documentation."""
     return render_template("data_index.html")
 
 

metobsapi/tests/test_files_api.py

@@ -82,7 +82,7 @@ class TestFilesAPI(unittest.TestCase):
         assert fn in res.data
 
     def test_tower_daily_ascii_relative_json(self):
-        """Test relative begin with defined end
+        """Test relative begin with defined end.
 
         Begin and end are relative to today so begin=-2 should mean the day
         before yesterday. End being set to yesterday's date should mean we get
@@ -98,7 +98,7 @@ class TestFilesAPI(unittest.TestCase):
         assert fn not in res.data
 
     def test_tower_daily_ascii_both_relative_json(self):
-        """Test relative begin and end
+        """Test relative begin and end.
 
         Begin and end are relative to today so begin=-2 and end=-2 should mean
         we only get 1 file for the day before yesterday.

metobsapi/util/__init__.py

 #!/usr/bin/env python
-"""Utility functions to help with testing and running hte MetObs API
-"""
+"""Utility functions to help with testing and running hte MetObs API."""
 
 import os
 from datetime import datetime
@@ -37,10 +36,10 @@ def create_fake_archive(archive_info, root=FAKE_ARCHIVE_PATH, datetimes=None):
     curr_dir = os.getcwd()
     os.makedirs(root, exist_ok=True)
     os.chdir(root)
-    for site, inst_info in archive_info.items():
+    for site, site_info in archive_info.items():
         os.makedirs(site, exist_ok=True)
         os.chdir(site)
-        for inst, inst_info in inst_info["instruments"].items():
+        for inst, inst_info in site_info["instruments"].items():
             os.makedirs(inst, exist_ok=True)
             os.chdir(inst)
             for level_name, level_info in inst_info["levels"].items():
@@ -50,7 +49,7 @@ def create_fake_archive(archive_info, root=FAKE_ARCHIVE_PATH, datetimes=None):
                     os.makedirs(version_name, exist_ok=True)
                     os.chdir(version_name)
                     for dt in datetimes:
-                        for pattern_name, pattern_info in level_info["products"].items():
+                        for pattern_info in level_info["products"].values():
                             if pattern_info["frequency"] not in FREQUENCY_DIR_FMT:
                                 raise RuntimeError("Unknown frequency '%s'", pattern_info["frequency"])
 

metobsapi/util/data_responses.py

+"""Configuration for data-based API responses."""
+
 SYMBOL_TRANSLATIONS = {
     ("aoss", "tower"): {
         "air_temp": "air_temp",

metobsapi/util/file_responses.py

+"""Configuration for file-based API responses."""
 import os
 from collections import defaultdict
 from typing import TypedDict
@@ -89,7 +90,8 @@ ARCHIVE_INFO: dict[str, SiteInfo] = {
                                 "frequency": ProductFrequency.DAILY_FILE,
                                 "pattern": "aoss_tower.accum_precip.%Y-%m-%d.png",
                                 "thumbnail_pattern": "aoss_tower.accum_precip.%Y-%m-%d_thumbnail.png",
-                                "display_name": "Daily Accumulated Precipitation (aoss_tower.accum_precip.YYYY-MM-DD.png)",
+                                "display_name": "Daily Accumulated Precipitation "
+                                "(aoss_tower.accum_precip.YYYY-MM-DD.png)",
                             },
                             "solar-flux-daily": {
                                 "frequency": ProductFrequency.DAILY_FILE,

metobsapi/util/query_influx.py

+"""Helpers for querying an InfluxDB backend."""
 from datetime import timedelta
 
 from flask import current_app

metobsapi_development.py

-import os
-
-from metobsapi.common_config import *
+"""Fake configuration options for testing."""
 from metobsapi.util import FAKE_ARCHIVE_PATH, create_fake_archive
 from metobsapi.util.file_responses import ARCHIVE_INFO
 

setup.cfg

 [flake8]
 max-line-length = 120
-ignore = D101,D102,D103,D104,D106,D107,W503,E203,B008
+ignore = D100,D101,D102,D103,D104,D106,D107,W503,E203,B008
 
 [coverage:run]
 relative_files = True