Dan's suggestions

rmq-setup

@@ -7,7 +7,7 @@
 # Sets up a RabbitMQ server's state for the SSEC                             #
 ##############################################################################
 
-trap "echo Exited! 1>&2; exit;" SIGINT SIGTERM
+trap "echo Exited! >&2; exit;" SIGINT SIGTERM
 #############################~Functions~######################################
 
 # $1 = error message, $2 = error code, default = 1
@@ -22,7 +22,7 @@ err_exit() {
     else
         CODE=$2
     fi
-    echo "$MSG" 1>&2
+    echo "$MSG" >&2
     exit "$CODE"
 }
 
@@ -44,8 +44,6 @@ usage() {
 }
 
 ##########################~Argument Parsing~##################################
-OPTIND=1 # Reset in case getopts has been used previously in the shell.
-
 config_file=""
 autorun=0
 no_exchanges=0
@@ -66,22 +64,19 @@ while getopts ":hanr" opt; do
     r)
         restart=1
         ;;
-    ? | *)
+    *)
         usage
-        exit 1
+        err_exit "Unknown option -$OPTARG"
         ;;
     esac
 done
 
-shift $((OPTIND - 1))
-[ "${1:-}" = "--" ] && shift
-
-config_file=$1
+config_file=${!OPTIND}
 
 # Check arguments
-if [ -z "$config_file" ]; then
+if [ $OPTIND -ne $# ]; then
     usage
-    exit 1
+    err_exit "Expected config file, got: '${*:OPTIND}'"
 fi
 
 if ! [ -f "$config_file" ]; then
@@ -89,7 +84,7 @@ if ! [ -f "$config_file" ]; then
 fi
 
 # load admin and user names and passwords
-source "$config_file" &>/dev/null
+source "$config_file"
 
 # Check config file
 if ! [[ -v ADMIN_PASS || -v ADMIN_NAME || -v USER_NAME || -v USER_PASS ]]; then
@@ -98,20 +93,20 @@ fi
 
 ########################~Check Requirements~################################
 # Check for rabbitmqctl command
-if ! command -v rabbitmqctl --version &>/dev/null; then
+if ! command -v rabbitmqctl --version >/dev/null 2>&1; then
     err_exit "rabbitmqctl command not found! Is RabbitMQ installed?"
 fi
 
-if ! rabbitmqctl status &>/dev/null; then
+if ! rabbitmqctl status >/dev/null 2>&1; then
     if [ 0 -eq "$autorun" ]; then
         err_exit "RabbitMQ server is not running! Use -a to autostart the server."
     else
         echo "Attempting to start the RabbitMQ server..."
-        rabbitmqctl status &>/dev/null
+        rabbitmqctl status >/dev/null 2>&1
         case "$?" in
         69)
             echo "RabbitMQ node is offline, attempting systemctl start rabbitmq-server..."
-            if ! systemctl start rabbitmq-server &>/dev/null; then
+            if ! systemctl start rabbitmq-server >/dev/null 2>&1; then
                 err_exit "Error trying to start RabbitMQ, systemctl error."
             fi
             ;;
@@ -136,9 +131,9 @@ if ! rabbitmq-plugins enable rabbitmq_management; then
 fi
 
 # Check for rabbitmqadmin (install if not found)
-if [ 0 -eq "$no_exchanges" ] && ! command -v rabbitmqadmin --version &>/dev/null; then
+if [ 0 -eq "$no_exchanges" ] && ! command -v rabbitmqadmin --version >/dev/null 2>&1; then
     # Check for python
-    if ! command -v python3 --version &>/dev/null; then
+    if ! command -v python3 --version >/dev/null 2>&1; then
         err_exit "python3 not found! Cannot create exchanges without it. (Use -n to skip creating excahnges)"
     fi
     if ! python3 -c "from urllib.request import urlretrieve;urlretrieve('http://$(hostname):15672/cli/rabbitmqadmin', '/usr/local/bin/rabbitmqadmin')"; then
@@ -177,13 +172,12 @@ fi
 
 # Set user permissions:
 # Can't configure or edit anything, but can read all default exchanges + model, misc, & satellite
-rabbitmqctl set_permissions --vhost '/' "$USER_NAME" "" "" "^(model|misc|satellite|amq\.gen.*|amq\.default)$"
+rabbitmqctl set_permissions "$USER_NAME" "" "" "^(model|misc|satellite|amq\.gen.*|amq\.default)$"
 
 # Remove default account
 rabbitmqctl delete_user guest
 
 ###########################~Set Exchanges~###################################
-
 if [ 0 -eq "$no_exchanges" ]; then    
     echo "Creating exchange 'model'"
     rabbitmqadmin -u "$ADMIN_NAME" -p "$ADMIN_PASS" -V '/' declare exchange name=model durable=true type=topic