Skip to content
Snippets Groups Projects

modifications for `Crisify` SIPS processing

Merged Dongwei Fu requested to merge crisify into master
1 unresolved thread
  1. Added CRIS FSR wavenumbers to cris.py and hs2modis.py
  2. Added shift_id to Cris2Modis in hs2modis.py
  3. Added C6.1 shifts for Terra and Aqua in modis_srf.py

Merge request reports

Approval is optional

Merged by Greg QuinnGreg Quinn 1 year ago (Oct 20, 2023 7:38pm UTC)

Merge details

  • Changes merged into master with 151e32ad (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
100 lambda_, rad_lambda = convert_to_wavelength_based_radiance(nu, rad_nu)
101
102 srf = self.srf_catalog.get(band)
103
104 rad_band = srf.apply(lambda_, rad_lambda)
105 bt_band = srf.bright(rad_band)
106
107 return rad_band, bt_band
108
109 def cris_wavenumber_fsr_domain(self):
110
111 return np.concatenate([np.linspace(648.75, 1096.25, 717),
112 np.linspace(1207.5, 1752.5, 869),
113 np.linspace(2150, 2555, 637)],
114 axis=-1)
115
  • My only piece of feedback: does it make sense to make NSR vs FSR a flag to the Cris2Modis constructor instead of making a new class?

  • Author Maintainer

    You're correct. I think it would be cleaner to make it a flag, back then when I added the function I was trying to avoid adding a flag to the working function that might break things...

  • Please register or sign in to reply
  • Dongwei Fu added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Greg Quinn mentioned in commit 151e32ad

    mentioned in commit 151e32ad

  • Please register or sign in to reply
    Loading