From f1e1986ea9e8c315bb7756b05765416c310f760f Mon Sep 17 00:00:00 2001
From: tomrink <rink@ssec.wisc.edu>
Date: Thu, 5 Aug 2021 15:52:24 -0500
Subject: [PATCH] slight reorder of tests in apply_qc_icing_pireps

---
 modules/icing/pirep_goes.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/modules/icing/pirep_goes.py b/modules/icing/pirep_goes.py
index c7fbe65f..8d81aca9 100644
--- a/modules/icing/pirep_goes.py
+++ b/modules/icing/pirep_goes.py
@@ -811,17 +811,20 @@ def apply_qc_icing_pireps(icing_alt, cld_top_hgt, cld_phase, cld_opd, cld_mask,
                 np.logical_and(cld_top_hgt[i,]+closeness > icing_alt[i], cld_top_hgt[i,]-closeness < icing_alt[i])),
                      False)
         # Test3
-        keep = np.where(keep, (cld_opd[i,] >= opd_thick_threshold) & (cld_phase[i,] == 4) & (cld_top_hgt[i,] > icing_alt[i]), False)
+        # keep = np.where(keep, (cld_opd[i,] >= opd_thick_threshold) & (cld_phase[i,] == 4) & (cld_top_hgt[i,] > icing_alt[i]), False)
 
         # Test4
         keep = np.where(keep, np.invert((cld_phase[i,] == 4) & (cld_opd[i,] < opd_thin_threshold) & (cld_top_hgt[i,] > icing_alt[i])), False)
 
-        # Test5, Should this go before Test2? (Would it flip some keepers from #2)
+        # Test5
         keep = np.where(keep, np.invert(bt_11um[i,] > 270.0), False)
 
         # Test6
         keep = np.where(keep, np.invert(bt_11um[i,] < 228.0), False)
 
+        # Test3
+        keep = np.where(keep, (cld_opd[i,] >= opd_thick_threshold) & (cld_phase[i,] == 4) & (cld_top_hgt[i,] > icing_alt[i]), False)
+
         mask.append(keep)
         idxs.append(i)
         num_tested.append(num_keep)
-- 
GitLab