The Mediam Distribution is computing the bins using the range()
function. When the user defines the stop
, the last bin edge is actually stop - interval
because of how the range()
function works. This needs to be corrected.
This shouldn't affect the computation of the median.
Median_Bins
attribute in the Median_Distribution variable should be changed to Median_Bin_Boundaries
for consistency with the attribute Histogram_Bin_Boundaries
in the histograms
issue solved
From Paul Hubanks (check email from 7/20/2023):
Hey Paolo, can you make a note to yourself, (Maybe stick it in your Calendar for a few weeks or more out) when you have a break in your schedule to fix this tiny bug in Yori. Just to keep things to your high standards!
For the Median Statistic, specified in the YAML file through a keyword, can you copy the local attribute “units” from the Mean stat to the Median stat. Shown below is a dump of a Yori L3 file where I specified Median Note that the Mean shows units of “percent” But there are no units specified for Median.
Everything else looks perfect I did visualize some Mean vs Median global stats and the numbers look right. So nice job coding Median.
Just fix the one tiny bug (whenever you have time). This local attribute for units being specified for median helps our automated visualization codes produce the best, most useful images, which people can interpret properly.
Paolo Veglio (cd141a95) at 24 Jul 17:47
bump version
Paolo Veglio (e67c1fd3) at 24 Jul 16:17
Paolo Veglio (e9ec05f5) at 24 Jul 16:17
fixed attributes not assigned to median. added --final option in yo...
... and 1 more commit
From Paul Hubanks (check email from 7/20/2023):
Hey Paolo, can you make a note to yourself, (Maybe stick it in your Calendar for a few weeks or more out) when you have a break in your schedule to fix this tiny bug in Yori. Just to keep things to your high standards!
For the Median Statistic, specified in the YAML file through a keyword, can you copy the local attribute “units” from the Mean stat to the Median stat. Shown below is a dump of a Yori L3 file where I specified Median Note that the Mean shows units of “percent” But there are no units specified for Median.
Everything else looks perfect I did visualize some Mean vs Median global stats and the numbers look right. So nice job coding Median.
Just fix the one tiny bug (whenever you have time). This local attribute for units being specified for median helps our automated visualization codes produce the best, most useful images, which people can interpret properly.
Paolo Veglio (e768d1c2) at 13 Jul 20:39
bump version
From a conversation with Rajeev Jain (jain@anl.gov) at SciPy 2023. Consider implementing an option to allow users to define sub-domains. For example if I'm only interested in a small region I could define a boundary box and my gridded/aggregated L3 files would be only confined to that boundary box instead of spanning the whole -90/+90;-180/+180 map.
Paolo Veglio (5c3991cf) at 13 Jul 18:56
modified cli tools to work wity pyinstaller
Paolo Veglio (22e5dc75) at 26 Jun 18:57
bump version
Paolo Veglio (4eac3728) at 26 Jun 18:57
bump version
Paolo Veglio (e795bf92) at 02 Jun 13:36
reverting to previous commit.
Paolo Veglio (48ced0a0) at 02 Jun 13:15
code cleanup and changelog update
Also, the documentation needs to be fixed. There is conflicting information between the definition of min_pixel_counts
and the example that follows
This could be one fix for #24
See #21 for information on the basic background. When specifying a variable's histogram using (start, stop, step)
in the gridding program, the edges
parameter is not included in the metadata. This causes problems when the aggregate code wants to read in the steps for a histogram. Note this behavior only appears when 1) specifying that a variable should be histogramed, 2) you only specify the start, stop and step instead of the edges, and 3) you run the aggregator code on the gridded files.
This MR solves the problem by 1) saving bin edges to the local settings dictionary after calculating them in the gridding code and 2) recalculating edges in the aggregate code.
Just (1) does not solve the problem because the metadata written out to the gridded files is actually the YAML file contents that were read in as opposed to a dump of the settings dictionary.