From eb6f1257ac24e2f078872d523f5e5f4815d20d95 Mon Sep 17 00:00:00 2001
From: Alan De Smet <alan.desmet@ssec.wisc.edu>
Date: Wed, 27 Jul 2016 17:17:49 -0500
Subject: [PATCH] Cleanup sorting code
Put sort directly into for loop; don't bother with giving it a variable.
Use named argument instead of relying on positional one.
---
pyglance/glance/compare.py | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/pyglance/glance/compare.py b/pyglance/glance/compare.py
index 8ae114c..603d39a 100644
--- a/pyglance/glance/compare.py
+++ b/pyglance/glance/compare.py
@@ -1024,9 +1024,7 @@ def stats_library_call(afn, bfn, var_list=[ ],
doc_each = do_document and len(names)==1
doc_atend = do_document and len(names)!=1
- sorted_names = sorted(names, None, lambda X:X[0]);
-
- for name, epsilon, missing in sorted_names:
+ for name, epsilon, missing in sorted(names, key=lambda X:X[0]):
# make sure that it's possible to load this variable
if not(aFile.is_loadable_type(name)) or not(bFile.is_loadable_type(name)) :
@@ -1105,10 +1103,8 @@ def inspect_stats_library_call (afn, var_list=[ ], options_set={ }, do_document=
doc_each = do_document and len(names)==1
doc_atend = do_document and len(names)!=1
- sorted_names = sorted(names, None, lambda X:X[0]);
-
- for name, epsilon, missing in sorted_names:
-
+ for name, epsilon, missing in sorted(names, key=lambda X:X[0]):
+
# make sure that it's possible to load this variable
if not(aFile.is_loadable_type(name)) :
LOG.warn(name + " is of a type that cannot be loaded using current file handling libraries included with Glance." +
--
GitLab